Review Request 128707: Add support for captive portals

[Jan Grulich]

> On Zář. 14, 2016, 8:36 dop., Kai Uwe Broulik wrote:
> > kded/portalmonitor.cpp, line 58
> > <https://git.reviewboard.kde.org/r/128707/diff/6/?file=476842#file476842line58>
> >
> >     Is it ensured that this notification doesn't constantly pop up, ie. does connectivity only change once I connect to a wifi (turns to "captive") and then again when I am authenticated? Ie. does it not cycle between various states at times?

That should be fine. Once you log in the connectivity state should just change to full connectivity. Even if we get notified from NM about changed state while the state is still same, we don't emit connectivityChanged() signal in nm-qt anyway.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/#review99159
-----------------------------------------------------------


On Zář. 14, 2016, 7:05 dop., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128707/
> -----------------------------------------------------------
> 
> (Updated Zář. 14, 2016, 7:05 dop.)
> 
> 
> Review request for Network Management, Plasma, KDE Usability, and Lamarque Souza.
> 
> 
> Bugs: 365417
>     http://bugs.kde.org/show_bug.cgi?id=365417
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> Adds portal monitor to our kded module, which checks NetworkManager connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we are behind a captive portal), then we open a QWebEngineView trying to load "http://kde.org" page which is supposed to be redirected to the captive portal page. Once user logs in and url changes, we re-check the connectivity again and close the web view if we are no longer behind the captive portal.
> 
> 
> Diffs
> -----
> 
>   kded/CMakeLists.txt 1f0613e 
>   kded/networkmanagement.notifyrc f95d94b 
>   kded/portalmonitor.h PRE-CREATION 
>   kded/portalmonitor.cpp PRE-CREATION 
>   kded/service.cpp 18ffd41 
> 
> Diff: https://git.reviewboard.kde.org/r/128707/diff/
> 
> 
> Testing
> -------
> 
> Tested with three different captive portals and it worked perfectly.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160914/497d39a4/attachment-0001.html>