[Differential] [Commented On] D2760: style and high dpi fixes for screen identification OSD

sebas (Sebastian Kügler) noreply at phabricator.kde.org
Tue Sep 13 14:20:26 UTC 2016


sebas added a comment.


  It would, and I played with it, but:
  
  This would need an ARGB window and also fallbacks to opaque components, at that point, we'd be duplicating much of the code in Plasma::Dialog (from plasmaquick). Since this code is hopefully going away for a yet-to-be-designed replacement mechanism, it isn't worth the hassle
  I'm not using the existing OSD since it doesn't allow us to place anything on a specific screen (kwin's job to decide), so it's pretty useless here. Extending that to allow what we need would mean going through KWindowSystem as well. I do think it's the proper solution in the end, and it would then also work on Wayland, but it's way too late for 5.8 now.
  
  This patch strikes I think a reasonable balance to make it a bit less ugly for 5.8 at least.

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D2760

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160913/385a840c/attachment.html>


More information about the Plasma-devel mailing list