Review Request 128897: cursor model: look for cursors in correct place

Tue Sep 13 12:04:17 UTC 2016

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128897/
-----------------------------------------------------------

(Updated Sept. 13, 2016, 12:04 p.m.)

Review request for Plasma, Aleix Pol Gonzalez and Thomas Pfeiffer.

Repository: kde-gtk-config

Description
-------

plasma-desktop's cursor theme kcm does the right thing, by consulting
the libXcursor library for the right search paths. Unfortunately, the
kcm here does a pretty butchered job of it. So, we copy, more or less,
the same algorithm used by plasma-desktop. Now there's parity in cursor
selection.

For reference, please see line 165 of:
https://quickgit.kde.org/?p=plasma-desktop.git&a=blob&f=kcms%2Fcursortheme%2Fxcursor%2Fthememodel.cpp

Diffs (updated)
-----

  CMakeLists.txt 07d313c0f6da20d0f0ad2b1e4db09d8b93395149 
  src/cursorthemesmodel.h 7658bd56ae9517e29be513e379b012bd9ae3f417 
  src/cursorthemesmodel.cpp 5238714671c36880a475da677302285a29b932d8 
  src/gtkconfigkcmodule.cpp 7afe69841c321b93e59292e55af02eaa81e831b5 

Diff: https://git.reviewboard.kde.org/r/128897/diff/

Testing
-------

Works extremely well, and since this is the same algorithm as with the other KCM, with code written years ago, it's certainly received quite a bit of testing.

Thanks,

Jason A. Donenfeld

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160913/b1f6bbe4/attachment.html>