[Differential] [Commented On] D2723: port panel loading away from ksycoca

mart (Marco Martin) noreply at phabricator.kde.org
Fri Sep 9 11:36:49 UTC 2016


mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in scriptengine_v1.cpp:490
> I'm a bit lost.
> 
> We have an argument to this method which is stored as local QString layout.
> 
> The old code found all Plasma/LayoutTemplates with that name.
> As far as I can tell, this finds all LayoutTemplates which contain any panel?
> 
> (and if we're not using layout, why are we still checking it on line 483)

actual plugin name now checked (and the application name isn't something really used anymore)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2723

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, andreaska, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160909/57378ce3/attachment.html>


More information about the Plasma-devel mailing list