[Differential] [Requested Changes To] D2723: port panel loading away from ksycoca

[davidedmundson (David Edmundson)]

davidedmundson requested changes to this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> scriptengine_v1.cpp:490
> +    {
> +        return md.value(QStringLiteral("X-Plasma-Shell")) == qApp->applicationName() && md.value(QStringLiteral("X-Plasma-ContainmentCategories")).contains(QStringLiteral("panel"));
> +    };

I'm a bit lost.

We have an argument to this method which is stored as local QString layout.

The old code found all Plasma/LayoutTemplates with that name.
As far as I can tell, this finds all LayoutTemplates which contain any panel?

(and if we're not using layout, why are we still checking it on line 483)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2723

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, andreaska, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160909/6ecb179d/attachment-0001.html>