[Differential] [Request, 20 lines] D2724: Make WindowPixmap::isValid virtual and override in concrete implementation

[graesslin (Martin Gräßlin)]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  If a buffer gets destroyed the texture created from it is still valid.
  In such a situation the OpenGLWindowPixmap should return true for isValid
  and not false as it did. Similar in QPainter compositor the pixmap is
  valid if there is an image copied from the buffer.
  
  This change ensures that for example minimizing an XWayland window
  still has a texture during the minimize animation.
  
  BUG: 368440

TEST PLAN
  Minimize animation plays for X windows and minimized windows
  are shown in present windows.

REPOSITORY
  rKWIN KWin

BRANCH
  pixmap-valid-override

REVISION DETAIL
  https://phabricator.kde.org/D2724

AFFECTED FILES
  scene.h
  scene_opengl.cpp
  scene_opengl.h
  scene_qpainter.cpp
  scene_qpainter.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160909/f5185d95/attachment.html>