Review Request 128856: Adds a check for kauthorized ghns so administrators can disable ghns if wanted

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128856/#review98992
-----------------------------------------------------------




src/button.cpp (line 79)
<https://git.reviewboard.kde.org/r/128856/#comment66663>

    Doesn't this need i18n? Also the wording is a bit technical.


- Kai Uwe Broulik


On Sept. 7, 2016, 9:43 nachm., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128856/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2016, 9:43 nachm.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez, Kai Uwe Broulik, and David Faure.
> 
> 
> Bugs: 368240
>     https://bugs.kde.org/show_bug.cgi?id=368240
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> This shows a messagebox if ghns dialogs are invoked either by the button or the dialog's exec, open, or show methods if ghns is disabled in kdeglobals (or the applications rc file).
> 
> 
> Diffs
> -----
> 
>   src/button.cpp 1772d86 
>   src/downloaddialog.h 0a39f5d 
>   src/downloaddialog.cpp b172e6a 
> 
> Diff: https://git.reviewboard.kde.org/r/128856/diff/
> 
> 
> Testing
> -------
> 
> Works ok except for the plasma wallpaper case which is doing some strange pointer.data() to set the window title and somehow goes around these checks. Need to figure out why it's doing that and if it's still neeeded there or how to catch those calls to show also.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160908/76c062a1/attachment.html>