[Differential] [Request, 154 lines] D2691: [Touchpad plasmoid] Major cleanup

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  - Use the compact representation for indicating status
  - In the expanded representation just place a button
  - Use declarative bindings as much as possible
  
  BUG: 368192
  FIXED-IN: 5.8.0

TEST PLAN
  I just wanted to fix the icon but then decided to give it a major cleanup.
  
  Tested:
  
  - Enabling / disabling
  - Disabling with no external mouse prompts for confirmation
  - With no touchpad the icon turns gray (and the applet should just hide completely but doesn't work in tray, see below)
  
  I stumbled upon two bugs in system tray:
  
  - When I have an applet with preferredRepresentation being expandedRepresentation systray tries to be smart and then expands on plasmashell startup and shows an empty spot for fthe applet
  - HiddenStatus applets are still shown in the popup list like PassiveStatus ones
  
  F278196: Screenshot_20160907_114941.png <https://phabricator.kde.org/F278196>
  
  Expanded representation in system tray, this is only accessible when in the popup and clicking the text of the applet instead of its icon. In all other cases clicking the icon just turns it on/off.
  F278197: Screenshot_20160907_115011.png <https://phabricator.kde.org/F278197>

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2691

AFFECTED FILES
  kcms/touchpad/src/applet/qml/contents/ui/touchpad.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160907/4c00c4df/attachment.html>