[Differential] [Commented On] D2365: Add failing test case for selected filter from mimetype

elvisangelaccio (Elvis Angelaccio) noreply at phabricator.kde.org
Tue Sep 6 15:47:17 UTC 2016


elvisangelaccio added a comment.


  In https://phabricator.kde.org/D2365#45684, @dfaure wrote:
  
  > The thing is, mimetype filters should be preferred above name filters. So the bug is in QFileDialog::selectMimeTypeFilter which "falls back" to selectNameFilter. Instead it should call some selectInitiallySelectedMimeTypeFilter in the options, like selectNameFilter does with setInitiallySelectedNameFilter, and QPlatformFileDialogHelper is missing a selectMimeTypeFilter.
  >
  > The fallback to selectNameFilter should only happen if d->usingWidgets() or d->selectMimeTypeFilter_sys() (to be added) fails.
  >
  > Feel like making a patch for Qt ?
  
  
  Patch up for review at https://codereview.qt-project.org/#/c/170332/

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D2365

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, graesslin, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160906/4d8e54b4/attachment.html>


More information about the Plasma-devel mailing list