[Differential] [Changed Subscribers] D2676: Improved and optimized Pager and Activity Pager

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in pagermodel.cpp:250
> emit countChanged in both places

couldn't be instead connected modelreset,rowsinserted,rowsdeleted signals to countchanged signal?

> davidedmundson wrote in pagermodel.cpp:429
> this is a new feature?
> 
> It doesn't work in the current version anyway.
> 
> Note there is a DBus verison of showDashboard which is maybe sensible to use? It cuts out some of the X specific code.

the current pager has it (settings, "when clicking on current desktop")

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2676

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160906/6b4cb94a/attachment.html>