[Differential] [Requested Changes To] D2652: Let the application control the menu further

[mart (Marco Martin)]

mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  almost good to go

INLINE COMMENTS

> GlobalDrawer.qml:369
>                                          stackView.push(menuComponent, {"model": modelData.children, "level": level + 1});
> -                                    } else {
> -                                        stackView.pop(stackView.initialItem);
> -                                        if (root.modal) {
> -                                            root.opened = false;
> -                                        }
> +                                    } else if (root.moveUpOnLeafAction) {
> +                                        root.resetMenu();

you renamed the property to resetOnMenuTriggered, so this should be updated as well

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2652

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: colomar, plasma-devel, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160906/b6a508b3/attachment-0001.html>