Review Request 128819: grid layout for windowdecoration KCM
Marco Martin
notmart at gmail.com
Tue Sep 6 11:23:04 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128819/#review98927
-----------------------------------------------------------
Ship it!
code now looks fine to me
- Marco Martin
On Sept. 4, 2016, 6:37 p.m., Andreas Kainz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128819/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2016, 6:37 p.m.)
>
>
> Review request for kwin and Plasma.
>
>
> Repository: kwin
>
>
> Description
> -------
>
> change the list layout to a grid layout and move the config button to the preview.
>
>
> Diffs
> -----
>
> kcmkwin/kwindecoration/qml/Previews.qml a146f86
>
> Diff: https://git.reviewboard.kde.org/r/128819/diff/
>
>
> Testing
> -------
>
> qml file was tested on my system.
>
>
> this is my first qml patch so be careful.
>
>
> File Attachments
> ----------------
>
> window decoration kcm update
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/03/91a3acab-b2c7-43d5-9f44-7ed71c1267fb__Screenshot_20160903_165718.png
>
>
> Thanks,
>
> Andreas Kainz
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160906/42830923/attachment.html>
More information about the Plasma-devel
mailing list