Review Request 128832: Take upload speed into account for maximum plotter value

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128832/#review98891
-----------------------------------------------------------




applet/contents/ui/ConnectionItem.qml (line 351)
<https://git.reviewboard.kde.org/r/128832/#comment66583>

    All of this could be simplified to:
        onValuesChanged: maxValue = Math.max.apply(null, downloadPlotData.values.concat(uploadPlotData.values))
        
    (if values behaves like a JS Array)
    
    Also, perhaps you can even bind that, ie.
        maxValue: Math.max(...)


- Kai Uwe Broulik


On Sept. 5, 2016, 9:09 vorm., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128832/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2016, 9:09 vorm.)
> 
> 
> Review request for Network Management and Plasma.
> 
> 
> Bugs: 368247
>     http://bugs.kde.org/show_bug.cgi?id=368247
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> When the upload speed is higher then the download we should set maximum plotter value based on that.
> 
> 
> Diffs
> -----
> 
>   applet/contents/ui/ConnectionItem.qml 3440e39 
> 
> Diff: https://git.reviewboard.kde.org/r/128832/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160905/39ec5f48/attachment.html>