[Differential] [Commented On] D2645: make sure the vertical systary size hints are fixed

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D2645#49198, @davidedmundson wrote:
  
  > Why is it needed?
  >
  > the panel containment is a layout - the system tray's current only size hint is minimum and it doesn't have a Layout.fillHeight - which means any other item which does have a fillHeight: true will force this system tray to it's minimum size. Effectively what this patch is doing.
  >
  > if no item with fillHeight exists, the panel will create a spacer (panel.qml checkLastSpacer) with Layout.fillHeight=true
  >  so we can always be sure (in theory) that something in that layout does have that.
  
  
  unfortunately seems to be needed in vertical panels.
  the taskbar should have fillHeight, and indeed scales correctly, without setting the maximum height, the systray gets stretched as well (i can reproduce the screenshot attached to https://bugs.kde.org/show_bug.cgi?id=368146) can you try locally if it reproduces for you?
  
  it tries to stretch the systray a bit (not huge, just a tad too much) never the less, hmm maybe preferredwidth defaults to too much?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2645

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160904/f764773a/attachment.html>