Review Request 128815: Fix themes list with SDDM 0.14

[David Edmundson]

> On Sept. 2, 2016, 6:17 p.m., Fabian Vogt wrote:
> > IMO you should use the same method as sddm, which is hardcoded at configure time: "@DATA_INSTALL_DIR@/themes".
> 
> Wolfgang Bauer wrote:
>     I agree.
>     This change will still make it use ~/.local/share/sddm/themes/ if it should exist for some reason, and ignore /usr/share/sddm/themes/ in that case.
>     
>     Or use QStandardPaths::locateAll(), but sddm only looks in "@DATA_INSTALL_DIR@/themes" anyway and will not load themes from ~/.local/share or other $XDG_DATA_DIRS locations.
> 
> Antonio Rojas wrote:
>     Wouldn't this break if plasma is installed in a custom prefix?

Effectively it's the exact same problem in two different ways.

Either kcm-sddm has to be *compiled* with the same setup as SDDM was installed or kcm-sddm has to be *run* with the same setup (XDG_DATA_DIRS) as SDDM was installed. 

In both cases the default matches SDDM, but can be different if SDDM/plasma has a different CMAKE_INSTALL_PREFIX.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128815/#review98833
-----------------------------------------------------------


On Sept. 2, 2016, 5:51 p.m., Antonio Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128815/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2016, 5:51 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: sddm-kcm
> 
> 
> Description
> -------
> 
> SDDM 0.14 apparently creates a ~/.local/share/sddm dir to store some logs, which makes sddm-kcm look for themes there instead of /usr/share/sddm
> Additionally, fix the config key for themes dir in sddm.conf
> 
> 
> Diffs
> -----
> 
>   src/themesmodel.cpp 5af9c54 
> 
> Diff: https://git.reviewboard.kde.org/r/128815/diff/
> 
> 
> Testing
> -------
> 
> Themes list works again with SDDM 0.14
> 
> 
> Thanks,
> 
> Antonio Rojas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160904/eec21ad8/attachment-0001.html>