Review Request 128802: task bar lines
Marco Martin
notmart at gmail.com
Fri Sep 2 08:23:58 UTC 2016
> On Sept. 2, 2016, 8:15 a.m., Marco Martin wrote:
> > no, don't like lines at the bottom for bottom panels at all, the whole point was to make it look the same as open plasmoids (which no, not going to change, at least not for 5.8).
> > i would rather keep the current squares then.
>
> Kai Uwe Broulik wrote:
> Agreed. The whole point was that active windows look like open plasmoids, so the line has to be at the top for bottom panels.
open plasmoids graphics can be eventually changed to use taskbar graphics (so it would be coherent again), but not sure i would want to do that so late for 5.8
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128802/#review98828
-----------------------------------------------------------
On Sept. 2, 2016, 7:16 a.m., Andreas Kainz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128802/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2016, 7:16 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Update of the tasks.svgz file
>
> focus task
> ----------
> had now a 3px height line in Highlight color (direction of the line is the same than the lines in kicker, system tray, ...
>
> normal task
> -----------
> no line no color at all no indicator. breeze mean no additional unusefull information and space for the elements to breath
>
> hover task
> ----------
> blue Highlight color line like focus task with additional Highlight color background and 24% opacity
>
> attention task
> --------------
> had a 3px height line in NeutralText color (old one didn't use colorscheme here)
>
> minimzed task
> -------------
> rectangular element with Text color and 0.16% opacity (you can see it now in breeze and breeze-dark color scheme)
>
> I know it's to late for kf5.26 (03.09) but however if you think it should be available with plasma 5.8 LTS let me know.
>
>
> Diffs
> -----
>
> src/desktoptheme/breeze/widgets/tasks.svgz 15a5921
>
> Diff: https://git.reviewboard.kde.org/r/128802/diff/
>
>
> Testing
> -------
>
> the stylesheed stuff were checked with different color schemes and with kate in the svg "source code".
>
>
> File Attachments
> ----------------
>
> the tasks.svgz file for your tests please copy it to your plasma theme dictionary
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/fe0f0fc4-2952-4711-8965-bfdca0eeaee1__tasks.svgz
> preview of the different tasks (inkscape file preview)
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/223b09e7-44a5-4431-bb7c-ad64a78a39e3__preview.png
> Breeze Preview
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/8c0dc0f2-88b5-4da8-84c5-d9acbb04c10e__Breeze.png
> Breeze Dark Color Scheme
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/6ab1fb1b-47bc-4a1b-a9ba-991d4371070c__Breeze-Dark.png
> Arch Color Scheme
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/c09eddcb-7026-400d-8246-3ed4f24a6e45__Arch.png
> Oxygen Color Scheme
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/4cfe2879-9234-4625-abcc-188942628e81__Oxygen.png
> Honeycomb color scheme
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/29/5ed41231-fddd-4b30-9087-f1e702ade7ac__Honeycomb.png
> update tasks file with suggestions from kai
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/5ba391cd-6bbc-43df-ab51-fcab9cbf964c__tasks.svgz
> Breeze Color Scheme with updated tasks.svgz file
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/202f150a-1011-4ca9-acfc-1811af24ae79__Screenshot_20160830_155736.png
> Breeze Dark Color Scheme with updated tasks.svgz file
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/88a6cb0d-571d-43e9-9901-8e55ac238073__Screenshot_20160830_155802.png
> Honeycomb Color Scheme with updated tasks.svgz file
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/f3be8584-bfb3-42e4-b687-87309615a9dd__Screenshot_20160830_155820.png
> now with ButtonHover for hover task
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/c068c5ab-341f-4c31-a94b-a737befa058b__tasks.svgz
> tasks are now always bottom lines
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/02/32ee725a-d73a-457b-a4cb-a00a3c1e49a7__tasks.svgz
> screenshot breeze-dark
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/02/685a840f-bffd-4868-a184-1b308a1aadbc__Screenshot_20160902_091022.png
>
>
> Thanks,
>
> Andreas Kainz
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160902/1aec9f57/attachment.html>
More information about the Plasma-devel
mailing list