Review Request 120829: Use full URL as filename for cached image files
Christoph Feck
cfeck at kde.org
Thu Sep 1 15:36:48 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120829/
-----------------------------------------------------------
(Updated Sept. 1, 2016, 3:36 p.m.)
Status
------
This change has been discarded.
Review request for Plasma and Anne-Marie Mahfouf.
Bugs: 340408
http://bugs.kde.org/show_bug.cgi?id=340408
Repository: kdeplasma-addons
Description
-------
Otherwise, two different URLs with the same filename would show up as identical images. prettyUrl() makes sure the password is removed from the string.
Diffs
-----
applets/frame/picture.cpp 635d845
Diff: https://git.reviewboard.kde.org/r/120829/diff/
Testing
-------
Yes. Cache files look like plasma-frame/http:||www.yr.no|place|United_States|New_York|New_York|meteogram.png
Thanks,
Christoph Feck
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160901/2a26fe30/attachment.html>
More information about the Plasma-devel
mailing list