[Differential] [Request, 12 lines] D3215: Simplify the window title passed in from the window system
graesslin (Martin Gräßlin)
noreply at phabricator.kde.org
Mon Oct 31 15:12:34 UTC 2016
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
So far KWin used the window title provided from the window directly
without any sanitizing. This could result in broken window decorations
if the title included line breaks. Those were passed to the decoration
and depending on the way how the decoration renders the title, it could
result in visual breakage.
Having line breaks in a window title doesn't make sense. Given that KWin
now simplifies the title when copying it to it's own structure. This
also ensures that the title passed to e.g. task manager does not have
any line breaks on Wayland.
BUG: 323798
FIXED-IN: 5.8.3
TEST PLAN
Opened the web page in a nested KWin, properly rendered now.
REPOSITORY
rKWIN KWin
BRANCH
simplified-title-5.8
REVISION DETAIL
https://phabricator.kde.org/D3215
AFFECTED FILES
autotests/integration/shell_client_test.cpp
autotests/integration/x11_client_test.cpp
client.cpp
shell_client.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161031/afe8503e/attachment.html>
More information about the Plasma-devel
mailing list