[Differential] [Changed Subscribers] D3212: Support drags from Widget Explorer onto System Tray

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> main.qml:241
> +        onDragEnter: {
> +            if (event.mimeData.formats.indexOf("text/x-plasmoidservicename") < 0) {
> +                event.ignore();

Can you split that into a function so we then have

  onDragEnter: {
      if (!isAcceptableDragEvent(event)) {
          event.ignore()
          return
      }
  }
  onDrop: {
      if (!isAcceptableDragEvent(event)) {
          event.ignore()
          return
      }
      ...
  }

> systemtray.h:100
>  
> +    Q_INVOKABLE bool isSystemTrayApplet(const QString &appletId);
> +

const

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3212

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161031/ffd19d18/attachment.html>