Review Request 129278: Don't reparse the metadata file if it's already loaded

Marco Martin notmart at gmail.com
Mon Oct 31 10:53:36 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129278/#review100426
-----------------------------------------------------------


Fix it, then Ship it!





src/plasma/package.h (line 350)
<https://git.reviewboard.kde.org/r/129278/#comment67400>

    needs apidoc and @since tag


- Marco Martin


On Oct. 28, 2016, 5:33 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129278/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2016, 5:33 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> By doing so, we don't tie ourselves to the desktop format as well as we leverage cached data.
> 
> 
> Diffs
> -----
> 
>   src/plasma/package.h 6687ed0 
>   src/plasma/package.cpp ada6a80 
>   src/plasma/packagestructure/packages.cpp a138dd9 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp 9ef2d03 
> 
> Diff: https://git.reviewboard.kde.org/r/129278/diff/
> 
> 
> Testing
> -------
> 
> Tests pass, all plasma desktop loads properly, even if I remove `.config/plasma-org.kde.plasma.desktop-appletsrc`
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161031/cfd034eb/attachment.html>


More information about the Plasma-devel mailing list