[Differential] [Request, 99 lines] D3211: Ensure that all Effects honour the grab roles correctly

[graesslin (Martin Gräßlin)]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma, broulik.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  When windows get added some effects grab the window and want to be the
  only one animating this window. For this the grab roles exists. An
  effect being notified later on evaluates the grab state and does not
  start the animation.
  
  This process failed due to being dependent on the order the effects are
  loaded. Window Added/Closed are signals emitted by EffectsHandler, thus
  first come, first serve. The requested effect order does not play into
  it.
  
  Due to that it could happen that an Effect which should not animate,
  started to animate as the grab was still there.
  
  This change adds the possibility to be notified whenever the window data
  changes. A new signal is added to EffectsHandler which is emitted
  whenever the windowData changes. The interested effects connect to it
  and cancel their (just started) animation for the window.
  
  Adjusted effects are:
  
  - ScaleIn
  - Fade
  - WobblyWindows
  
  In case of WobblyWindows an additional logical error was fixed that the
  animations were only run when an effect grabbed instead of the other way
  around.
  
  BUG: 336866
  FIXED-IN: 5.8.3

REPOSITORY
  rKWIN KWin

BRANCH
  window-grab-add-close-honored-5.8

REVISION DETAIL
  https://phabricator.kde.org/D3211

AFFECTED FILES
  autotests/integration/effects/slidingpopups_test.cpp
  effects.cpp
  effects/fade/package/contents/code/main.js
  effects/scalein/package/contents/code/main.js
  effects/slidingpopups/slidingpopups.cpp
  effects/wobblywindows/wobblywindows.cpp
  effects/wobblywindows/wobblywindows.h
  libkwineffects/kwineffects.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, broulik
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161031/f1797081/attachment.html>