Questions on Plasma i18n strings, offset=39

[Alexander Potashev]

Hi Sebastian,

2016-04-08 13:12 GMT+03:00 Sebastian Kügler <sebas at kde.org>:
> On Friday, April 08, 2016 01:54:07 AM Alexander Potashev wrote:
>>  60. Please clarify in the msgctxt that %1 is the name of the device,
>> not name of a medium (e.g. optical disc).
>> plasma_engine_devicenotifications.po-22-#: ksolidnotify.cpp:156
>> plasma_engine_devicenotifications.po-23-msgid "This device can now be
>> safely removed."
>>
>>  61. Please clarify in the msgctxt that %1 is the name of the disc
>> inserted into device (disc reader), not name of device (disc reader).
>> plasma_engine_devicenotifications.po-44-#: ksolidnotify.cpp:206
>> plasma_engine_devicenotifications.po-45-msgid "One or more files on
>> this device are open within an application."
>
> Neither of the above contains a %1, seems to be an old version.

You are right, sorry for my mistake.

>>  63. This will expand to e.g. ""myusername (on 7 (0))". Double closing
>> parenthesis do not look good.
>> plasma_lookandfeel_org.kde.lookandfeel.po-109-#:
>> contents/lockscreen/ChangeSession.qml:57
>> plasma_lookandfeel_org.kde.lookandfeel.po-110-msgctxt "Username (location)"
>> plasma_lookandfeel_org.kde.lookandfeel.po-111-msgid "%1 (%2)"
>
> Seems already fixed.

Not really: "%1 (%2)" is still there, and now it will expand as
"myusername (on TTY 7 (Display 0))" with the same double closing
parentheses. I think it should be "myusername (on TTY 7, display 0)".

>>  65. Are these messages visible in the UI?
>> plasma_runner_audioplayercontrol.po-295-#:
>> audioplayercontrolrunner_config.cpp:171
>> plasma_runner_audioplayercontrol.po-296-msgid "Quit"
>
> They're all used, but a bit hidden: Open the Search KCM, then hover over the
> "Control Audio Player" entry, on the right hand side, there's a configure
> button which opens this UI.

Found them, thanks! :)

>>  67. This is not specific enough. Please change to "Configure activity".

>> plasma_shell_org.kde.plasma.desktop.po-33-#:
>> contents/activitymanager/ActivityItem.qml:320
>> plasma_shell_org.kde.plasma.desktop.po-34-#:
>> contents/activitymanager/StoppedActivityItem.qml:146
>> plasma_shell_org.kde.plasma.desktop.po-35-msgid "Configure"
>
> All done.

You have missed "Configure" in contents/activitymanager/ActivityItem.qml.


-- 
Alexander Potashev