[Differential] [Request, 3 lines] D3192: The combobox needs to be 2 pixels wider for contents to fit

[antlarr (Antonio Larrosa Jimenez)]

antlarr created this revision.
antlarr added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When the size of the combo box adjusts to its contents, the dropdown
  listbox isn't large enough to fit the contents and a vertical scrollbar
  so instead of using Metrics::MenuButton_IndicatorWidth. I defined
  a new Metrics::ComboBox_IndicatorWidth which is two pixels larger than
  Metrics::MenuButton_IndicatorWidth.
  
  To test this I used "kcmshell5 kcm_kscreen -style breeze" and opened
  the resolutions QComboBox (If there are less than 15 possible
  resolutions, a slider will appear instead of a QComboBox, so in that
  case it's possible to use a virtual machine with QXL video that for
  me shows plenty of possible resolutions).
  
  Before this patch, most of the larger resolutions are shortened to
  something like "192...200" or "160...200" and can't be read (in the
  dropdown listbox, when selected they can be read correctly in the
  closed combobox), after applying this patch, all the contents of the
  listbox can be read correctly.

REPOSITORY
  rBREEZE Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3192

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezestyle.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antlarr, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161028/8ff8b2f1/attachment.html>