[Differential] [Updated, 2,660 lines] D3086: RFC: Clean up KAppMenu
broulik (Kai Uwe Broulik)
noreply at phabricator.kde.org
Fri Oct 28 13:59:14 UTC 2016
broulik updated the summary for this revision.
broulik updated this revision to Diff 7727.
broulik added a comment.
- Remove GtkIcons, it's not like GTK applications support this stuff anymore...
- Introduce showMenu signal so KWin can reliably know whether the menu actually showed (sometimes when the menu doesn't show up for reasons, KWin would get stuck thinking it's open, so we explicitly emit a signal when we popup'd the menu)
- Listen to ItemActivationRequested signal we emit in Plasma-Integration, when called with 0,0 arguments we emit a generic "show menu" request
- Re-introduce Unity about to show hack but it doesn't actually fix the situation with Firefox for me :/
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3086?vs=7572&id=7727
REVISION DETAIL
https://phabricator.kde.org/D3086
AFFECTED FILES
appmenu/CMakeLists.txt
appmenu/appmenu.cpp
appmenu/appmenu.h
appmenu/appmenu_dbus.cpp
appmenu/appmenu_dbus.h
appmenu/glowbar.cpp
appmenu/glowbar.h
appmenu/gtkicons.h
appmenu/kdbusimporter.h
appmenu/menubar.cpp
appmenu/menubar.h
appmenu/menubutton.cpp
appmenu/menubutton.h
appmenu/menuimporter.cpp
appmenu/menuimporter.h
appmenu/menuwidget.cpp
appmenu/menuwidget.h
appmenu/org.kde.kappmenu.xml
appmenu/shadows.cpp
appmenu/shadows.h
appmenu/topmenubar.cpp
appmenu/topmenubar.h
appmenu/verticalmenu.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161028/9b8eae33/attachment.html>
More information about the Plasma-devel
mailing list