[Differential] [Request, 89 lines] D3177: Add support for desktopFileName provided by NETWinInfo

[graesslin (Martin Gräßlin)]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland, hein.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  KWindowSystem provides a KDE specific property for the desktop file
  name. This allows KWin to take the icon from the desktop file. The
  advantage from the desktop file is that KWin normally gets higher
  resolution icons than provided through the xproperty based icons used
  previously. If the desktop file does not provide an icon name, KWin
  falls back to the previous implementation.
  
  As on Wayland the icon is taken from the desktop file name already the
  code for X11 and Wayland is merged in AbstractClient. Also to the
  PlasmaWindowInterface the appId is taken from the new desktop file
  instead of the resourceName. Due to that for Xwayland windows where KWin
  knows the desktop file name it can be passed to PlasmaWindowInterface.
  This allows e.g. the task manager to better map the windows to
  applications and provide better icons. Also it means that icons do not
  need to be passed as bitmap data to the clients.

TEST PLAN
  Verified that icon is taking from desktop file if provided and
  from X property if not provided and that Wayland windows still have icon.

REPOSITORY
  rKWIN KWin

BRANCH
  desktop-file-name-x11

REVISION DETAIL
  https://phabricator.kde.org/D3177

AFFECTED FILES
  abstract_client.cpp
  abstract_client.h
  client.cpp
  events.cpp
  manage.cpp
  shell_client.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, hein
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161027/fda35258/attachment.html>