Review Request 129255: Fixed unrar version check.
Massimiliano Torromeo
massimiliano.torromeo at gmail.com
Mon Oct 24 21:26:23 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129255/
-----------------------------------------------------------
Review request for Plasma.
Repository: kio-extras
Description
-------
The parameter "--version" stopped working since unrar 5.2 which was
released almost 2 years ago.
With this change this now becomes the minimum version required but
every distribution that is going to include a version of KDE with
this commit has probably been using unrar > 5.2 for quite a while
so I don't think there is any need to provide a fallback.
This fixes bugs 367626 and 341305
Diffs
-----
thumbnail/comiccreator.cpp 4ec0db8c6953e2d9983e4a9d7f542b27404175e4
Diff: https://git.reviewboard.kde.org/r/129255/diff/
Testing
-------
Verified that the previously missing thumbnails for cbr files are now being correctly generated.
Thanks,
Massimiliano Torromeo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161024/08c9de61/attachment.html>
More information about the Plasma-devel
mailing list