[Differential] [Updated] D3130: Improve Activity Pager Layout for horizontal and vertical cases

mvourlakos (Michail Vourlakos) noreply at phabricator.kde.org
Mon Oct 24 21:12:20 UTC 2016


mvourlakos marked 2 inline comments as done.
mvourlakos added a comment.


  In https://phabricator.kde.org/D3130#58604, @hein wrote:
  
  > Do you have commit access?
  
  
  unfortunately not yet...
  this is my first patch for plasma...

INLINE COMMENTS

> hein wrote in main.qml:199
> Please add comments like /* Horizontal */ into the conditions for readability (I wish we could generate proper enums from config ...).

Hein, is there a way in QML to generate proper enums from config?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3130

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mvourlakos, mart, hein, #plasma
Cc: mvourlakos, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161024/dc57fe63/attachment.html>


More information about the Plasma-devel mailing list