[Differential] [Request, 49 lines] D3148: [server] Ensure we have a DataSource on the DataDevice in setSelection

[graesslin (Martin Gräßlin)]

graesslin created this revision.
graesslin added a reviewer: Plasma on Wayland.
Restricted Application added a subscriber: plasma-devel.
Restricted Application added a project: Plasma on Wayland.

REVISION SUMMARY
  SeatInterface provides a way to set the current selection. This method
  did not verify whether the new DataDeviceInterface actually has a
  DataSourceInterface. If there is no DataSourceInterface on that
  DataDeviceInterface the selection should not be sent to the current
  selection owner. This results in a crash as DataOfferInterface
  (correctly) doesn't expect the passed in DataSourceInterface to be null.
  
  To ensure we don't hit this again the DataOfferInterface ctor gained an
  Q_ASSERT to validate the DataSourceInterface.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  set-selection-source

REVISION DETAIL
  https://phabricator.kde.org/D3148

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/server/dataoffer_interface.cpp
  src/server/seat_interface.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161024/22dd73c3/attachment.html>