[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL
luebking (Thomas Lübking)
noreply at phabricator.kde.org
Sun Oct 23 18:38:49 UTC 2016
luebking added inline comments.
INLINE COMMENTS
> antlarr wrote in x11_platform.cpp:215
> The timer is in another thread, so it can't be stopped/restarted from this thread.
You should be able to call it as slot (whether QMetaObject::invokeMethod() works, I've never tried)
> antlarr wrote in x11_platform.cpp:224
> The config is not written in every frame. It's only saved when the timer is triggered. That is, when a freeze is detected. That was the point of the "remove overhead" commit.
Sorry, misread. (Actually didn't really read and just wanted to point out the other case ;-)
REVISION DETAIL
https://phabricator.kde.org/D3132
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: antlarr, #kwin, #plasma, davidedmundson
Cc: luebking, graesslin, kwin, plasma-devel, davidedmundson, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161023/e8708ec8/attachment.html>
More information about the Plasma-devel
mailing list