[Differential] [Request, 22 lines] D3127: [platformx/x11] Add a freeze protection against OpenGL
graesslin (Martin Gräßlin)
noreply at phabricator.kde.org
Fri Oct 21 11:07:59 UTC 2016
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
With nouveau driver it can happen that KWin gets frozen when first trying
to render with OpenGL. This results in a freeze of the complete desktop
as the compositor is non functional.
Our OpenGL breakage detection is only able to detect crashes, but not
freezes. This change improves it by also added a freeze protection.
In the PreInit stage a thread is started with a QTimer of 15 sec. If the
timer fires, qFatal is triggered to terminate KWin. This can only happen
if the creation of the OpenGL compositor takes longer than said 15 sec.
In the PostInit stage the timer gets deleted and the thread stopeed
again.
Thus if a freeze is detected the OpenGL unsafe protection is written into
the config. KWin aborts and gets restarted by DrKonqui. The new KWin
instance will no longer try to activate the freezing OpenGL as the
protection is set.
If KWin doesn't freeze the protection is removed from the config as
we are used to.
REPOSITORY
rKWIN KWin
BRANCH
opengl-freeze-protection-5.8
REVISION DETAIL
https://phabricator.kde.org/D3127
AFFECTED FILES
plugins/platforms/x11/standalone/x11_platform.cpp
plugins/platforms/x11/standalone/x11_platform.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161021/8d8c4dc2/attachment-0001.html>
More information about the Plasma-devel
mailing list