Review Request 128957: Make KF5Baloo optional

Thu Oct 20 20:07:17 UTC 2016

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128957/
-----------------------------------------------------------

(Updated Oct. 20, 2016, 8:07 p.m.)

Review request for Plasma and David Edmundson.

Changes
-------

rebased on top of latest changes, changed from OPTIONAL to RECOMMENDED dependency.

Repository: plasma-desktop

Description
-------

https://mail.kde.org/pipermail/kde-frameworks-devel/2016-September/037734.html

Regardless of the current state of Baloo, it is not very deeply tied into Plasma. Usage in plasma-desktop comes down to providing the file search kcm.

Diffs (updated)
-----

  CMakeLists.txt cf2e79a8eaf12c944fea845ff688840a561abf6b 
  kcms/CMakeLists.txt 53ca49a4d17a05c3d8d9a6a4c2e37a6ec0fd9284 

Diff: https://git.reviewboard.kde.org/r/128957/diff/

Testing
-------

Several days of Plasma-5 without any issues. Usage of krunner without any segfaults.

Thanks,

Andreas Sturmlechner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161020/9100ed96/attachment.html>