[Differential] [Commented On] D3088: [KDecoration] Restore application menu button

[sitter (Harald Sitter)]

sitter added inline comments.

INLINE COMMENTS

> graesslin wrote in decoratedclientprivate.h:79
> @sitter with your distro hat on: what do you think works best? We have here a public api with a "private" library which is used by KWin.

Even if the API is public... plasma libs have no ABI stability promise so I think it's easiest to simply bump the so version. That way distributions can't accidently build kwin against the wrong version of libkdecoration and then have odd vtable crashes. And since this is only BIC but not SIC it's only a minor rebuild inconvenience to anyone who's using libkdecoration's public API.

That said, a fully backwards compatible addition using a subclass is of course always nicer :)

REPOSITORY
  rKDECORATION Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D3088

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: sitter, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161020/954ed9ba/attachment.html>