[Differential] [Commented On] D3079: Adapt Dashboard: Connect to new toggled signal instead of activated signal in order to initiate state change

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS

> main.qml:47
>  
> +    Plasmoid.shrinkOnReactivation: !isDash
> +

If you want this to be in Plasma/5.8.x we can't rely on this being available.

Plasma 5.8.x *has* to still work with frameworks 5.26.

You can either go master only

or do the following:

Component.onCompleted: {
if (Plasmoid.hasOwnProperty("shrinkOnReactivation")) {

  shrinkOnReactivation = !isDash

}
}

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3079

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, graesslin, broulik
Cc: davidedmundson, plasma-devel, #plasma, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161018/bba94bb6/attachment.html>