Review Request 129203: Fixes for building plasma-framework

[Alberto Curro]

> On Oct. 17, 2016, 8:37 a.m., David Edmundson wrote:
> > src/declarativeimports/core/windowthumbnail.cpp, line 231
> > <https://git.reviewboard.kde.org/r/129203/diff/2/?file=482311#file482311line231>
> >
> >     FWIW: https://git.reviewboard.kde.org/r/129065/

I've changed the code, given a comment in your own review, to choose the right RenderStage based on the version of Qt available. Please check the updated patch.


- Alberto


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129203/#review100069
-----------------------------------------------------------


On Oct. 17, 2016, 7:35 a.m., Alberto Curro wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129203/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2016, 7:35 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Being a newbie, following build instruction from the wiki, I could not build plasma-framework on my Linux mint 18 (based on Ubuntu Xenial).
> 
> Two of the changes are coding issues.
> 
> The change in CMakeLists.txt comes from a wrong required version, also stated here: https://git.reviewboard.kde.org/r/128763/. 
> 
> For Xenial, QT 5.5.1-2 is included, where QQuickWindow::NoStage is **not** defined. It was introduced in Qt 5.6, so requiring Qt 5.3 won't work.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/windowthumbnail.cpp 0453c09 
>   src/plasmaquick/dialog.cpp eac9ee5 
>   src/plasmaquick/dialogshadows.cpp eb67926 
> 
> Diff: https://git.reviewboard.kde.org/r/129203/diff/
> 
> 
> Testing
> -------
> 
> Building is ok now. I've had to add a second ppa for Qt 5.7 on Xenial: https://launchpad.net/~beineri/+archive/ubuntu/opt-qt57-xenial
> 
> 
> Thanks,
> 
> Alberto Curro
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161017/2d0267a4/attachment.html>