[Differential] [Request, 2,180 lines] D3086: RFC: Clean up KAppMenu

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This is part two in a series to restore global menu support in Plasma.
  
  Massively cleanup KAppMenu by removing outdated and unused code. The global menu has been removed as it will eventually be provided by a plasmoid (famous last words). Also many of the workarounds (like the unity about to show hack) have been removed and will only get re-introduced if they are in fact still neccessary.

TEST PLAN
  Added the following to ~/.config/kdeglobals
  
    [Appmenu Style]
    Style=ButtonVertical
  
  Applications like Kwrite, Dolphin, as well as VLC start exporting their manus on DBus now. The "showMenu" method on the org.kde.kappmenu dbus interface can be used to show the application menu.
  
  The about to show hack seemed to have been neccessary for the global menu which is updated as soon as the active menu changes; right now calling showMenu does work with Firefox.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3086

AFFECTED FILES
  appmenu/CMakeLists.txt
  appmenu/appmenu.cpp
  appmenu/appmenu.h
  appmenu/glowbar.cpp
  appmenu/glowbar.h
  appmenu/kdbusimporter.h
  appmenu/menubar.cpp
  appmenu/menubar.h
  appmenu/menubutton.cpp
  appmenu/menubutton.h
  appmenu/menuimporter.cpp
  appmenu/menuimporter.h
  appmenu/menuwidget.cpp
  appmenu/menuwidget.h
  appmenu/shadows.cpp
  appmenu/shadows.h
  appmenu/topmenubar.cpp
  appmenu/topmenubar.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161017/08b1b868/attachment.html>