[Differential] [Commented On] D3079: Adapt Dashboard: Connect to new toggled signal instead of activated signal in order to initiate state change

[subdiff (Roman Gilg)]

subdiff added a comment.


  In https://phabricator.kde.org/D3079#57067, @davidedmundson wrote:
  
  > This breaks the normal keyboard shortcut working at all.
  >
  > You either need to connect to both or
  >
  > if we put in the addition emit I suggest in https://git.reviewboard.kde.org/r/129204/
  >  and then you don't need this change.
  
  
  Does it not work on your system? Have you also applied the other diffs on phab mentioned in the reviewboard diff? It shouldn't break the normal keyboard shortcut. It works on my system.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3079

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, graesslin, broulik
Cc: davidedmundson, plasma-devel, #plasma, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161017/20b7deb6/attachment.html>