[Differential] [Commented On] D3019: [kstyle] Implement window moving on Wayland

hpereiradacosta (Hugo Pereira Da Costa) noreply at phabricator.kde.org
Sun Oct 16 15:15:15 UTC 2016


hpereiradacosta added inline comments.

INLINE COMMENTS

> breezewindowmanager.cpp:264
> +            [registry, this] {
> +                const auto interface = registry->interface( Registry::Interface::Seat );
> +                if( interface.name != 0 ) {

mmm. I know delta functions are handy, but isn't this one a tad complicated ? Personnally I find this code quite hard to read. (especially the sequence of closing }s and )s later on ...

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3019

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, hpereiradacosta
Cc: sebas, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161016/d793410f/attachment.html>


More information about the Plasma-devel mailing list