[Differential] [Changed Subscribers] D3035: Add request to have focus in a PlasmaShellSurface of Role Panel

[subdiff (Roman Gilg)]

subdiff added inline comments.

INLINE COMMENTS

> plasma-shell.xml:373
> +      </description>
> +      <arg name="skip" type="uint" summary="Boolean value that sets wether the panel takes focus"/>
> +    </request>

Use another name instead of "skip" (copy paste from set_skip_taskbar) ?

> plasmashell_interface.cpp:90
>      static void panelAutoHideShowCallback(wl_client *client, wl_resource *resource);
> +    static void panelTakesFocusCallback(wl_client *client, wl_resource *resource, uint32_t skip);
>  

Name "skip" of argument like in line 373.

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D3035

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland
Cc: subdiff, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161015/6090b5db/attachment-0001.html>