[Differential] [Commented On] D3049: Support passing generic QIcon through PlasmaWindow interface

[graesslin (Martin Gräßlin)]

graesslin added inline comments.

INLINE COMMENTS

> roberts wrote in plasmawindowmanagement_interface.cpp:406
> Is there anything protecting this from being unsynchronised parallel access to m_icon (and p)?
> 
> Simplest solution might be passing the icon by value into the lambda.

I assumed that reading from the icon is thread save. But you are right: better save than sorry. Especially accessing the p pointer could be dangerous as the PlasmaWindowInterface instance might get deleted.

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D3049

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, hein
Cc: roberts, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161014/c659b0c6/attachment.html>