[Differential] [Updated] D3051: [applets/notification] Add nullptr check

broulik (Kai Uwe Broulik) noreply at phabricator.kde.org
Fri Oct 14 07:07:57 UTC 2016


broulik added a comment.


  While in principle the patch is fine, the only way this can be null is when NotificationPopup.qml (which is a Plasma Dialog) failed to load, so I think we're masking a deeper problem here.
  
    var popup = notificationPopupComponent.createObject();
    notificationPositioner.addNotificationPopup(popup);

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3051

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161014/d95ce941/attachment.html>


More information about the Plasma-devel mailing list