[Differential] [Request, 61 lines] D3044: Set color scheme X property in the X11Integration

graesslin (Martin Gräßlin) noreply at phabricator.kde.org
Thu Oct 13 06:22:34 UTC 2016


graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  So for the _KDE_NET_WM_COLOR_SCHEME property was set in KStyle. This has
  a few disadvantages:
  
  - it only works for QWidgets
  - it requires a style inheriting from KStyle
  
  This change brings the behavior into the plasma-integration QPT. It's an
  integration feature for our platform theme as it's a hint for KWin.
  
  The existing event filter in the X11Integration is used to monitor for
  all PlatformSurface events and sets the required property on the newly
  created X11 window.
  
  In addition it monitors for the ApplicationPaletteChange to update the
  property as needed on all toplevel windows.

TEST PLAN
  Removed code from kstyle and used the KColorSchemeManager test
  application.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

BRANCH
  color-scheme-atom

REVISION DETAIL
  https://phabricator.kde.org/D3044

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  src/platformtheme/CMakeLists.txt
  src/platformtheme/x11integration.cpp
  src/platformtheme/x11integration.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161013/0011067b/attachment.html>


More information about the Plasma-devel mailing list