Review Request 129148: use kwayland for shadows and dialog positioning
Marco Martin
notmart at gmail.com
Tue Oct 11 14:59:29 UTC 2016
> On Oct. 11, 2016, 2:58 p.m., Martin Gräßlin wrote:
> > src/plasmaquick/CMakeLists.txt, lines 7-11
> > <https://git.reviewboard.kde.org/r/129148/diff/2/?file=481966#file481966line7>
> >
> > why are you adding the definition if you have it in config-plasma.h?
right, config-plasma.h is for libplasma, not for libplasmaquick, so i should probably remove it from config-plasma.h
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129148/#review99937
-----------------------------------------------------------
On Oct. 11, 2016, 2:44 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129148/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2016, 2:44 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> use plasmashell interface for moving the dialog, use kwayland as well for shadows.
>
> this is supposed to replace the waylanddialogfilter hack in plasmashell.
>
>
> Diffs
> -----
>
> CMakeLists.txt 74b0704
> src/plasma/config-plasma.h.cmake ed14e7a
> src/plasmaquick/CMakeLists.txt 2dd6a26
> src/plasmaquick/dialog.cpp 5c8879d
> src/plasmaquick/dialogshadows.cpp 982de15
> src/plasmaquick/dialogshadows_p.h f8c6207
>
> Diff: https://git.reviewboard.kde.org/r/129148/diff/
>
>
> Testing
> -------
>
> ran a plasma session in wayland, both with the p-w hack enabled and siabled, dialogs move and shadows seem to be fine
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161011/c3243dd8/attachment.html>
More information about the Plasma-devel
mailing list