Review Request 128526: Make BINARY_ICONS_RESOURCE ON by default

[Jarosław Staniek]

> On July 27, 2016, 2:01 p.m., Jarosław Staniek wrote:
> > Update: the script of build.kde.org sets BINARY_ICONS_RESOURCE to ON, nevertheless everyone who compiles breeze-icons needs to know it's needed. It's hard to say not buiulding the rcc files gives any important optimization. The cost is like 10MiB for white and 10MiB for dark file while build dir of a single app is measured in GiBs.
> 
> Andreas Kainz wrote:
>     Hi,
>     I can't reply any technical stuff. in the future I will only shipp breeze icons cause the breeze icons will be styles for breeze-dark. and in general I updated ALL icons to reduce the file size to a minimum that you can use them on windows, osx, ...
> 
> Jarosław Staniek wrote:
>     @Andreas
>     Thanks for reducing the size. In sum a single theme is smaller after that but installing them or updating installations does not take secon, it's still thousands of files to create when applications typically consist of a few hundreds or less. On portable devices (pen drives) it's even more expensive to copy a single file. I am not looking for reducing total size but (which is small even if a no file currently can be smaller than 4096 bytes e.g. on Windows) but for installation and access time. I understand this is not a topic for you -- that's a deployment thing. You'd doing great work.
>     
>     Styling the base breeze icons to fit a dark (or any altered background) seems good - it's also my approach in my experimental version of Kexi. (https://blogs.kde.org/2016/06/01/kexi-3)
> 
> Andreas Kainz wrote:
>     In general the app developer has to say which icons are needed e.g. 95% of the apps need actions, status and maybe places with mimetype. action icons for 24px are only for gtk apps the 32px are ordinary not needed maybe for hidpi so that the app dev can reduce the installed files but yes if you only install the needed icons it would be best.

Update: I've found that 24px icons are for at least one more target: Windows. 16/22/32 are all blurry there for the default QToolBar in Windows 7 style. Only when 24px is supplied, things are OK. At least I am trying not to support any extra widget style than Breeze in Kexi project (leaving fixes to others, never in default installation), but for all others it might be an issue.

After months of using rcc files (and even rcc file per plugin) I am happe to see how compact the installation of larger app is, and how it works quite OK from a pendrive.


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128526/#review97865
-----------------------------------------------------------


On July 26, 2016, 11:35 a.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128526/
> -----------------------------------------------------------
> 
> (Updated July 26, 2016, 11:35 a.m.)
> 
> 
> Review request for Plasma and Andreas Kainz.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> -------
> 
> Make BINARY_ICONS_RESOURCE ON by default. Otherwise packagers will not create packages with breeze-icons.rcc. Let them possible create split packages - 1 with icon files and 1 with the rcc file.
> 
> Also our Jenkins fails to create the file, apps have no way to add dependency on breeze-icons "with rcc", there's just breeze-icons that we can depend on.
> Example failure: https://build.kde.org/job/kexi%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/lastFailedBuild/console
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c0623ca 
> 
> Diff: https://git.reviewboard.kde.org/r/128526/diff/
> 
> 
> Testing
> -------
> 
> breeze-icons now installs the .rcc file.
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161011/1ddbebc1/attachment.html>