[Differential] [Commented On] D2981: Removes preferred definition so a new wallpaper is selected.

antlarr (Antonio Larrosa Jimenez) noreply at phabricator.kde.org
Tue Oct 11 06:48:29 UTC 2016


antlarr added inline comments.

INLINE COMMENTS

> mart wrote in image.cpp:245
> shouldn't then "preferred" just not be defined anymore in the wallpaper package structure then?

Sorry, I don't get your comment. That's why I remove it, so that "preferred" is not defined anymore and the next call to Image::findPreferedImageInPackage doesn't have a "preferred" wallpaper so a new one is chosen that respects the new aspect ratio for the new m_targetSize value.
Note that the first line in findPreferedImageInPackage is:
if (!package.filePath("preferred").isEmpty()) return;

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2981

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antlarr, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161011/800b6b2a/attachment.html>


More information about the Plasma-devel mailing list