Review Request 129143: Fix loading plasmoids by absolute path, fixes configmodeltest

Marco Martin notmart at gmail.com
Mon Oct 10 21:32:34 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129143/#review99917
-----------------------------------------------------------



I confirm Kai's findings, to me it breaks loading of the whole panel.
emergency-reverting the commit now, tomorrow a proper one should be made instead

- Marco Martin


On Oct. 10, 2016, 6:44 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129143/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2016, 6:44 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> We were not looking into the plugin directory when figuring out the applet path.
> 
> 
> Diffs
> -----
> 
>   src/plasma/private/applet_p.cpp 624e4fe 
>   src/plasmaquick/configmodel.cpp 975854a 
> 
> Diff: https://git.reviewboard.kde.org/r/129143/diff/
> 
> 
> Testing
> -------
> 
> `configmodeltest` passes.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161010/41201abc/attachment.html>


More information about the Plasma-devel mailing list