[Differential] [Request, 13 lines] D3008: [shell] Don't resize or reposition panel if we are doing restore

bshah (Bhushan Shah) noreply at phabricator.kde.org
Mon Oct 10 15:57:39 UTC 2016


bshah created this revision.
bshah added reviewers: Plasma, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  PanelView::restore sets various properties including length, thickness,
  which would result in panel resize and repositioning. PanelView::restore
  also explicitly calls PanelView::positionPanel and ::resizePanel.
  
  This results in positionPanel and resizePanel operation being done
  multiple times at startup/adding panel and hence flicker when panel
  first shows up. This patch makes resizePanel and positionPanel no-op if
  we are restoring panel.

TEST PLAN
  Added panel, restored panel, moved around panel

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3008

AFFECTED FILES
  shell/panelview.cpp
  shell/panelview.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161010/3220454f/attachment.html>


More information about the Plasma-devel mailing list