[Differential] [Request, 13 lines] D3006: fix screenForContainment when screen ids > count

mart (Marco Martin) noreply at phabricator.kde.org
Mon Oct 10 14:14:25 UTC 2016


mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  the check that was there, screen id not being more
  than screen count is not valid anymore with the
  screenpool approach, a screen id can be bigger than
  the screen count in cases such as middle screen of a 3 screen
  system disabled, or driver change (in which unfortunately,
  connector names can change)
  without this, a new containment was created for each startup.
  
  BUG:369665

TEST PLAN
  created a puroposefully corrupted plasmashellrc file,
  where one known screen has a big number as id.
  without patch a new containment is added in appletsrc each time
  with the patch it behaves fine.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  phab/screenforcont

REVISION DETAIL
  https://phabricator.kde.org/D3006

AFFECTED FILES
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161010/1ecf65df/attachment.html>


More information about the Plasma-devel mailing list