Review Request 129102: Don't enforce metadata.desktop, cleanup constructor
David Edmundson
david at davidedmundson.co.uk
Mon Oct 10 10:35:38 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129102/#review99900
-----------------------------------------------------------
+1
- David Edmundson
On Oct. 7, 2016, 3:23 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129102/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2016, 3:23 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Makes it possible to use plugins that offer a metadata.json file.
> Define the service type when falling back to the desktop file parser, so the type system is proper.
> Don't destroy a KPluginMetadata tuple to instanciate it right away.
>
>
> Diffs
> -----
>
> src/plasma/applet.cpp 5eb529c
> src/plasma/containment.h 0b7a3ef
> src/plasma/containment.cpp 1840f24
> src/plasma/pluginloader.h 566461d
> src/plasma/pluginloader.cpp db2b2c9
> src/plasma/private/applet_p.cpp fafb450
>
> Diff: https://git.reviewboard.kde.org/r/129102/diff/
>
>
> Testing
> -------
>
> Tests still pass, plasma still loads, even with RR #129103.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161010/2487540b/attachment.html>
More information about the Plasma-devel
mailing list