Review Request 128956: Make KF5Baloo optional

Marco Martin notmart at gmail.com
Mon Oct 10 08:32:55 UTC 2016



> On Oct. 10, 2016, 12:05 a.m., David Edmundson wrote:
> > Ship It!

still don't totally agree.
actually, the proposal of disabling the runner when indexing is disabled makes sense.


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128956/#review99897
-----------------------------------------------------------


On Sept. 20, 2016, 12:06 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128956/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2016, 12:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> https://mail.kde.org/pipermail/kde-frameworks-devel/2016-September/037734.html
> 
> Regardless of the current state of Baloo, it is not very deeply tied into Plasma. Usage in plasma-workspace comes down to providing the baloo runner.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9da918358bd797b8fe00de646b6576ba22976d0e 
>   runners/CMakeLists.txt 48cc3799f834a57031ae387a35f41859178fe317 
> 
> Diff: https://git.reviewboard.kde.org/r/128956/diff/
> 
> 
> Testing
> -------
> 
> Several days of Plasma-5 without any issues. Usage of krunner without any segfaults.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161010/397f6f83/attachment-0001.html>


More information about the Plasma-devel mailing list