[Differential] [Request, 6 lines] D2995: No-op SeachRunner if indexing is disabled

davidedmundson (David Edmundson) noreply at phabricator.kde.org
Mon Oct 10 00:36:37 UTC 2016


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We won't have any results anyway.

TEST PLAN
  Disabled indexing and put a qDebug in the if branch
  
  I'm not super convinced it's a good idea myself. It means parsing a config file every match
  and it can't be cached without missing updates if the user enables/disables at runtime.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2995

AFFECTED FILES
  runners/baloo/baloosearchrunner.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161010/2674142f/attachment.html>


More information about the Plasma-devel mailing list